review (S) for 6857159: local schedule failed with checkcast of Thread.currentThread()
Vladimir.Kozlov at Sun.COM
Tue Jul 21 16:09:34 PDT 2009
Tom Rodriguez wrote:
> I changed the name to skip_antidep_check and put in a more extensive
> On Jul 21, 2009, at 2:31 PM, Tom Rodriguez wrote:
>>> Can you use is_immutable_load() instead of uses_immutable_memory()
>>> since it is load from immutable memory?
>> That's what I had originally and I changed it since it's technically
>> not quite true. The LoadKlass that reads from the cache isn't
>> actually reading immutable memory since the cache can be updated,
>> though never by generated code. Neither name is really right. Maybe
>> it should just be disable_antidep_check with a comment explaining why?
>>> And change comment to include LoadRange:
>>> // node matches ideal 'LoadKlassNode' 'LoadNKlassNode'
>>> // node matches ideal 'LoadKlass' 'LoadNKlass' 'LoadRange'
>>> Tom Rodriguez wrote:
More information about the hotspot-compiler-dev