Request for reviews .02 (XS): 6863155: Server compiler generates incorrect code (x86, long, bitshift, bitmask)

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue Jul 28 09:11:58 PDT 2009

Looks good.


On Jul 27, 2009, at 1:10 PM, Christian Thalinger wrote:

> Christian Thalinger wrote:
>> Tom Rodriguez wrote:
>>> Don't you just want to replace the existing mask with
>>> 0xffffffff80000000 to test for this?  Testing separately is  
>>> unneeded.
>> Yeah, Vladimir also asked me that question.  I wanted to do that,  
>> but I
>> thought it's easier to understand when kept separated.  But I think I
>> change it and write a good comment.
> Here is the updated webrev:
> -- Christian

More information about the hotspot-compiler-dev mailing list