Request for reviews (M): 6829192: JSR 292 needs to support 64-bit x86
Vladimir.Kozlov at Sun.COM
Tue Oct 20 17:32:24 PDT 2009
In InterpreterMacroAssembler::get_cache_index_at_bcp() the assert
is not clear. Add comment and explain what you are testing to how
next instruction should be changed.
what rbx and rax contain and why you need to verify oop?
I don't like outline code in generate_return_entry_for().
Why do you need to move it down?
Don't leave commented code. Remove it if you don't need it.
Christian Thalinger wrote:
> Let's start the review round with a patch that does not fit logically
> into the order but is small:
> -- Christian
More information about the hotspot-compiler-dev