Request for reviews (M): 6829192: JSR 292 needs to support 64-bit x86
Christian.Thalinger at Sun.COM
Wed Oct 21 08:15:15 PDT 2009
On Tue, 2009-10-20 at 17:32 -0700, Vladimir Kozlov wrote:
> In InterpreterMacroAssembler::get_cache_index_at_bcp() the assert
> is not clear. Add comment and explain what you are testing to how
> next instruction should be changed.
> In TemplateInterpreterGenerator::generate_WrongMethodType_handler()
> what rbx and rax contain and why you need to verify oop?
I can only tell what the registers contain, John should know why it
needs to be verified.
> I don't like outline code in generate_return_entry_for().
> Why do you need to move it down?
I guess John wrote it that way because it's not the default case. John?
> Don't leave commented code. Remove it if you don't need it.
Yeah, that commented code was just a hack to get it working, the real
fix is to add this field "magically". John and I decided to do that
after M5. But I will remove the commented code.
More information about the hotspot-compiler-dev