Request for review (XS): 6893554: SPECjvm2008 mpegaudio fails with SecurityException
Vladimir.Kozlov at Sun.COM
Fri Oct 23 10:35:57 PDT 2009
Christian Thalinger wrote:
> On Fri, 2009-10-23 at 09:45 -0700, Vladimir Kozlov wrote:
>> Thank you for finding the cause so fast.
>> The fix looks good. I am only concern about
>> using #ifdef inside ins_encode and format.
>> Could you verify the generated code for both
>> 32- and 64-bit VM?
> I don't like it either. We could use the 64-bit code for 32-bit too,
> but it's one (useless) instruction more.
I would just remove #ifdef and use extra shift always.
One additional instruction will not affect performance but
will guaranty the correctness since in 32-bit VM the upper
bit of src register could be set also.
> The generated code with the patch is OK for 32- and 64-bit. I tested
> that with my initial testcase.
> That leads me to another question: as I would have noticed the bug when
> I wouldn't have forgotten to actually run the testcase on 64-bit SPARC,
> aren't we running the compiler tests somewhere on a nightly basis?
I looked on Nightly and the test passed:
But they running on Niagara 1 machines which does not have popc
so this code is not exercised.
> -- Christian
More information about the hotspot-compiler-dev