Request for review (XS): 6893554: SPECjvm2008 mpegaudio fails with SecurityException

Christian Thalinger Christian.Thalinger at Sun.COM
Fri Oct 23 10:44:31 PDT 2009

On Fri, 2009-10-23 at 10:35 -0700, Vladimir Kozlov wrote:
> I would just remove #ifdef and use extra shift always.
> One additional instruction will not affect performance but
> will guaranty the correctness since in 32-bit VM the upper
> bit of src register could be set also.

Good point.  I will remove the #ifdef and post another webrev.

> I looked on Nightly and the test passed:
>   Passed: compiler/6823354/
> But they running on Niagara 1 machines which does not have popc
> so this code is not exercised.

Ahh, that explains it :-/

-- Christian

More information about the hotspot-compiler-dev mailing list