Request for reviews (XS): 6879902: CTW failure jdk6_18/hotspot/src/cpu/sparc/vm/assembler_sparc.hpp:845

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue Sep 22 10:10:26 PDT 2009

We could convert arg_slot/next_arg_slot to return RegisterOrConstant  
and fix this uniformly.  The existing code assumes that the offsets  
fit in 32 bit mode but don't in 64 bit which seems dubious.  arg_slot  
could then be used everywhere, as long as we add an assert that  
value_offset_in_bytes == 0.


On Sep 22, 2009, at 9:57 AM, Christian Thalinger wrote:

> Tom Rodriguez wrote:
>> I actually told him not to since using arg_slot in i2c adapters  
>> seemed
>> dubious to me since it adds in Interpreter::value_offset_in_bytes().
>> I guess since the rest of the i2c code uses it we should use it but
>> I'd like an assert that value_offset_in_bytes() == 0 in arg_slot.  I
>> don't really like that i2c always forces constants into Rdisp instead
>> of using the simm13 variants.  I think all of these should be using
>> RegisterOrConstant and ensure_rs2 to deal with this issue.
> Should I roll that into my change?  -- Christian

More information about the hotspot-compiler-dev mailing list