review (S) for 6915557: assert(_gvn.type(l)->higher_equal(type), "must constrain OSR typestate") with debug build

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Feb 24 18:13:32 PST 2010


So it is safe to skip the type check at this place because
in an other place (in ciTypeFlow) we already have such check?

Your new comment says that we don't do type check because it will fail anyway
but it does not explain why it is safe to skip it at that place.


Tom Rodriguez wrote:
> 6915557: assert(_gvn.type(l)->higher_equal(type),"must constrain OSR typestate") with debug build
> Reviewed-by:
> The fix for 6892079 to eliminate asserts about address types in OSR
> was insufficient because sometimes method liveness may consider locals
> to live that actually aren't because of the conservativeness of its
> analysis.  I think the fix is simply to not check address types.  If
> the OSR entry point has any live address we will fail this test but
> the resonsibility for making sure that we don't actually have a live
> jsr during OSR entry is managed by ciTypeFlow itself so it should be
> safe to simply skip the check.  Tested with failing test case.
> src/share/vm/opto/parse1.cpp

More information about the hotspot-compiler-dev mailing list