Review Request: Zero fix for 32-bit platforms
gbenson at redhat.com
Mon Jan 18 03:48:42 PST 2010
Christian Thalinger wrote:
> On Mon, 2010-01-18 at 11:09 +0000, Gary Benson wrote:
> > Recent changes in arguments.cpp mean that
> > os::allocatable_physical_memory is now always called at VM startup.
> > On 32-bit platforms this calls os::is_allocatable which was not
> > implemented in Zero. This webrev implements this:
> > http://cr.openjdk.java.net/~gbenson/zero-is_allocatable/
> > The implementation provided is essentially a copy of the one from
> > os_linux_x86.cpp. It was contributed by Edward Nevill, an SCA
> > signatory. I modified his contribution by replacing the AMD64
> > conditional with _LP64 to make the code generic.
> I can't find Edward on http://db.openjdk.java.net/people/, so I
> can't verify he's an SCA signatory. Have there already been pushed
> contributions of Edward?
> Otherwise we have to wait for Mark to show up and either verify that
> he is or--even better--update the db list.
He's listed on https://sca.dev.java.net/CA_signatories.htm#n.
More information about the hotspot-compiler-dev