Request for review (L): 6921352: JSR 292 needs its own deopt handler (new CR for 6917766)

Christian Thalinger Christian.Thalinger at Sun.COM
Fri Jan 29 10:09:06 PST 2010

On 01/25/10 05:15 PM, Christian Thalinger wrote:
> On Thu, 2010-01-21 at 16:35 -0800, John Rose wrote:
>> Reviewed.  But, can you factor the new assert code for frames some
>> more?  I like what it does, but it is hard to read, because it uses a
>> scratch frame to carry an argument, and it is repetitive.  It would be
>> great if the 2-3 checks repeated could be merged into a single
>> debug-only sanity check routine.
> Yes, you're right.  Here is an updated webrev and I keep the check in
> Deoptimization::fetch_unroll_info_helper:

Puh, what a day.  For those who haven't noticed yet, today I
accidentally pushed a changeset (6917766) to hotspot-comp/hotspot/
without JPRT and the changeset broke the tree.

So I created another CR 6921339 to backout the changes, which is
currently in the JPRT queue and should be in soon.

This one, finally, will be the CR to push the changes for 6917766:

Sorry for the mess...

-- Christian

More information about the hotspot-compiler-dev mailing list