Request for reviews (S): 6997311: SIGFPE in new long division asm code
tom.rodriguez at oracle.com
Fri Nov 5 14:29:50 PDT 2010
I think I follow the new code and it looks ok. One typo: Fallthrow -> fallthrough.
On Nov 4, 2010, at 10:42 AM, Vladimir Kozlov wrote:
> Fixed 6997311: SIGFPE in new long division asm code
> Regression after changes added for 6987135.
> IDIV instruction throws SIGFPE if sign of result
> does not fit into 32 bit. I have to use unsigned
> DIV instruction and convert negative dividend
> to positive and result back. So more code.
> Added missing cast to long in 6603011/Test.java
> which prevented me to catch this situation during
> work on 6987135. Added additional verification
> output for failure (the same as for int testing).
> Tested with failed Nightly tests and fixed 6603011/Test.
More information about the hotspot-compiler-dev