Request for review(XL): 6985015: C1 needs to support compressed oops

Igor Veresov igor.veresov at
Fri Nov 19 14:32:18 PST 2010

Vladimir, thanks for the review!

On 11/19/10 12:19 PM, Vladimir Kozlov wrote:
> Typo in assembler_sparc.cpp, should be srl().

Oh, right! Last minute change. :( Thanks!

> I have the same comment as Christian's about using separate lduw/stw and
> decode/encode, they should be combined if you can't use existing functions.

Yes, like Tom noted in some places this can be avoided by introducing 
store_heap_oop() with an extra temporary so as not to kill the dst oop 
register. I'll think about how these think can be done in a better way 
and put out the updated webrev.


> Looks good otherwise.
> Thanks,
> Vladimir
> Igor Veresov wrote:
>> This change implements compressed oops for C1 for x64 and sparc.
>> The changes are mostly on the codegen level, with a few exceptions
>> when we do access things outside of the heap that are uncompressed
>> from the IR.
>> Webrev:
>> Thanks,
>> igor

More information about the hotspot-compiler-dev mailing list