Request for reviews (XXL): 6961690: load oops from constant table on SPARC
christian.thalinger at oracle.com
Thu Nov 25 07:57:55 PST 2010
On Nov 18, 2010, at 8:30 PM, Vladimir Kozlov wrote:
> I like this code better but I still think that we should have a flag
> which controls how we load constant oops and longs.
> We may do it by just adding predicate(flag) into .ad file. Could you,
> please, check? And yes, we may need to keep some code you removed.
> Instead of using new flag ConstantTableAbsoluteAddressing (we have more
> flags than we need already) you should use Matcher's variable like next:
> const bool Matcher::clone_shift_expressions = true;
Good idea. I didn't like the flag either.
> I don't understand how MachConstantBaseNode::size() is not called
> on sparc where there is code generated for it? You need the size.
> It seems, you have to calculate it manually.
SPARC does not use Compile::Shorten_branches and that's the only place where I got calls to size.
> I think you don't need to add_req() in constructor and then use
> set_req(root) since new MachConstantBase node is only created in
> Compile::mach_constant_base_node() so you can add_req(root) there
I will send out a review later or tomorrow.
More information about the hotspot-compiler-dev