Updated request for reviews (S): 6984348

Tom Rodriguez tom.rodriguez at oracle.com
Wed Sep 15 12:04:44 PDT 2010

Can you explain what problem the old code was checking for and how the new code handles that?  If m == orig_mem why do we use find_inst_mem to look it up?  Wouldn't it make more sense for find_inst_mem to be used only in the assert?


On Sep 15, 2010, at 11:15 AM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6984348/webrev.01
> Fixed 6984348: Fix typo in escape.cpp
> After fixing typo the assert produces false negative results.
> It does not take into account that Loads don't have output
> memory edge and Stores may have several memory users.
> I removed this code and added few asserts into move_inst_mem().
> Tested with CTW and NSK.

More information about the hotspot-compiler-dev mailing list