Review request: flush the output streams before OnError commands
rasbold at google.com
Wed Sep 15 14:26:44 PDT 2010
Thanks for looking at this.
I'll admit I originally overlooked SuppressFatalErrorMessage, and I'm not
familiar with conventional use of the option.
After looking at it, the intent of that flag seems to be to avoid all post
fatal error processing. See bug
Under that description, I would argue that flushing the streams is
post-error processing, and my changes are in keeping with that.
If you don't agree with me, do you think calling ostream_abort() before
os::abort() is the right thing to do?
My last preference would be to leave the calls in the OS specific shutdown
On Wed, Sep 15, 2010 at 11:38 AM, Vladimir Kozlov <
vladimir.kozlov at oracle.com> wrote:
> When -XX:+SuppressFatalErrorMessage the log files will not be flushed.
> Chuck Rasbold wrote:
>> I've found the LogCompilation files incomplete when a JIT crashes and
>> OnError is used to move the files.
>> NoBugId: Contributed-by: rasbold at google.com <mailto:rasbold at google.com>
>> When the VM aborts, flush the output streams before OnError commands are
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev