review request (L): 6981777 implement JSR 292 EG adjustments from summer 2010
christian.thalinger at oracle.com
Mon Sep 20 03:31:02 PDT 2010
On Mon, 2010-09-20 at 02:25 -0700, John Rose wrote:
> On Sep 20, 2010, at 12:57 AM, Christian Thalinger wrote:
> > src/share/vm/classfile/classFileParser.cpp:
> > + cfs->guarantee_more(3, CHECK); // operand_count, ..., tag/access_flags
> > + u2 op_count = cfs->get_u2_fast();
> > + cfs->guarantee_more(2*op_count + 1, CHECK);
> > I think the additional +1 is wrong as you check for 3 in the first
> > guarantee_more.
> Yes, but that 3 only assures the tag will be present if op_count==0.
> The way this big loop works is everybody has to ensure that the next
> guy's tag is already loaded.
> So almost every guarantee_more has to have a +1.
Makes sense. -- Christian
More information about the hotspot-compiler-dev