review (S) for 6982537: Crash in Node*step_through_mergemem

Vladimir Kozlov vladimir.kozlov at
Wed Sep 22 10:59:21 PDT 2010

Thank you, Tom, for fixing this.

Few notes.
In escape.cpp TypeInstPtr was not renamed in the comment.
Also check for "memcpy" is not related to this changes.


Tom Rodriguez wrote:
> 6982537: Crash in Node*step_through_mergemem
> Reviewed-by:
> Code which was examining the type of memory was attempting to
> introspect on the klass of TypeOopPtr but wasn't checking for NULL
> which led to crashes when it looked at a primitive array type.  The
> fix is to check for NULL.  I also updated similar code in escape.cpp
> and corrected variable names to match the types.  Tested with failing
> test from bug report.
> src/share/vm/opto/memnode.cpp
> src/share/vm/opto/escape.cpp

More information about the hotspot-compiler-dev mailing list