Request for review: 7117052 instanceKlass::_init_state can be u1 type
david.holmes at oracle.com
Sun Dec 4 18:17:59 PST 2011
On 3/12/2011 4:55 AM, Jiangli Zhou wrote:
> Hi David,
> Thanks for catching that. I changed the debug version of
> set_init_state(). The updated webrev is
Thanks - that update looks fine.
Have you run SA tests to confirm no impact on SA code?
Have you run any performance tests?
> On 12/01/2011 05:18 PM, David Holmes wrote:
>> As already mentioned in internal email, there seem to be changes
>> missing for debug builds. In instanceKlass set_init_state has two
>> implementations - one for product and one for debug. The debug version
>> has not been modified to accommodate the change in type.
>> On 2/12/2011 4:51 AM, Jiangli Zhou wrote:
>>> The instanceKlass::_init_state is defined as instanceKlass::ClassState
>>> type, which is an enum. Currently there are 7 class states defined. The
>>> instanceKlass::_init_state can be changed to u1 type, which could hold
>>> up 256 states. There are unused bytes after
>>> instanceKlass::_idnum_allocated_count field. Changing _init_state to u1
>>> and move it to after the _idnum_allocate_count field would save 4-byte
>>> for each loaded class.
More information about the hotspot-compiler-dev