review (XS) for 7019819: bare oop in ciField

Tom Rodriguez tom.rodriguez at
Tue Feb 15 19:34:49 PST 2011



On Feb 15, 2011, at 5:01 PM, Vladimir Kozlov wrote:

> Talked with Tom, should use Handle here so changes are fine.
> Vladimir
> Vladimir Kozlov wrote:
>> Should we use KlassHandle instead of simple Handle?
>> Vladimir
>> Tom Rodriguez wrote:
>>> 7019819: bare oop in ciField
>>> Reviewed-by:
>>> This appears to be a long standing issue though it was previously
>>> unlikely to occur.  There's a bare oop in initialize_from over a call
>>> to ciField::type which may call compute_type, which make call into
>>> ciEnv::get_klass_by_name_impl where a safepoint could potentially
>>> occur.  The fix for 6354181 added acquire of the Compile_lock which
>>> made it more likely that we might safepoint here.  The fix is properly
>>> handleize the oop over the call.  Tested with failing test from nightly.

More information about the hotspot-compiler-dev mailing list