review (XS) for 7019819: bare oop in ciField

Igor Veresov igor.veresov at
Tue Feb 15 20:31:51 PST 2011

Looks good, year in the header needs fixing.


On 2/15/11 3:50 PM, Tom Rodriguez wrote:
> 7019819: bare oop in ciField
> Reviewed-by:
> This appears to be a long standing issue though it was previously
> unlikely to occur.  There's a bare oop in initialize_from over a call
> to ciField::type which may call compute_type, which make call into
> ciEnv::get_klass_by_name_impl where a safepoint could potentially
> occur.  The fix for 6354181 added acquire of the Compile_lock which
> made it more likely that we might safepoint here.  The fix is properly
> handleize the oop over the call.  Tested with failing test from nightly.

More information about the hotspot-compiler-dev mailing list