Request for review(M): 7020521: arraycopy stubs place prebarriers incorrectly
igor.veresov at oracle.com
Tue Feb 22 14:23:52 PST 2011
On 2/22/11 1:02 PM, Tom Rodriguez wrote:
> On Feb 22, 2011, at 11:57 AM, Igor Veresov wrote:
>> I rearranged the pre-barrier placement in arraycopy stubs so that they are properly called in case of chained calls. Also refactored the code a little bit so that it looks uniform across the platforms and is more readable.
>> Webrev: http://cr.openjdk.java.net/~iveresov/7020521/webrev.00
> So the fix part of this is moving the gen_write_ref_array_pre_barrier to after the external entry point instead of before it? If so then I understand it and the rest looks fine.
That's right. It's after the entry point in all the cases and also after
the dispatching happens. So only the actual method that does the copying
executes a prebarrier.
More information about the hotspot-compiler-dev