review request (L): 7012650: implement JSR 292 EG adjustments through January 2010

Rémi Forax forax at
Thu Jan 20 15:09:48 PST 2011

On 01/20/2011 10:23 PM, John Rose wrote:
> The webrev is refreshed; there are now changes to
> -- John

Hi John,
I suppose that classValueFrom() shoud be static.
The implementation of FromMethodhandle.computeValue() creates a hole in 
the typesystem.
You mix parameterized type (T) and MethodHandle that aren't typed by the 

return (T) result;  // this cast is unsafe and not enforced anywhere

I wonder if it's not better to wait the introduction of lambda here.


> On Jan 20, 2011, at 11:59 AM, John Rose wrote:
>> These are the rest of the EG-requested changes for JSR 292:
>> After these changes, plus some renames, we will be ready for formal Public Review.
>> (The two deprecated methods were going to be removed, but we ran into some minor technical problems, which we are working on.)
>> -- John

More information about the hotspot-compiler-dev mailing list