review for 7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries
tom.rodriguez at oracle.com
Tue Jul 12 18:05:16 PDT 2011
On Jul 12, 2011, at 4:20 PM, John Rose wrote:
> On Jul 11, 2011, at 10:50 AM, Tom Rodriguez wrote:
>>> Is the debugging code in isValid intentional?
>> No. Thanks for catching that. I've fixed it.
> In that function there is a new line; is it really needed?
> || ctag.isMethodHandle() || ctag.isMethodType()
> + || ctag.isMethod()
> || ctag.isInt() || ctag.isFloat())? true: false;
Yes that was required for it to pass. Is that unexpected? This code has no parallel in the C++ code.
> The rest of it looks fine.
> Some of the new Java code it resembles the corresponding C++ code, in that it seems like code that should be distrusted until it is fully exercised by tests.
What are you saying?
> -- John
More information about the hotspot-compiler-dev