review for 7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries
john.r.rose at oracle.com
Tue Jul 12 19:01:41 PDT 2011
On Jul 12, 2011, at 6:05 PM, Tom Rodriguez wrote:
> Yes that was required for it to pass. Is that unexpected? This code has no parallel in the C++ code.
Yes, I'm surprised that somebody is making a reference to a CONSTANT_Methodref from something related to ldc or a bootstrap method specifier (or some other constant-loading construct).
>> The rest of it looks fine.
>> Some of the new Java code it resembles the corresponding C++ code, in that it seems like code that should be distrusted until it is fully exercised by tests.
> What are you saying?
I'm saying that it's fine, but since I did not mentally prove the change correct (which is possible sometimes), I'm relying on the testing to catch errors.
More information about the hotspot-compiler-dev