review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods
tom.rodriguez at oracle.com
Thu Jul 14 12:49:38 PDT 2011
On Jul 12, 2011, at 9:38 AM, Christian Thalinger wrote:
> On Jul 11, 2011, at 5:43 PM, Christian Thalinger wrote:
>> On Jul 9, 2011, at 12:21 AM, Tom Rodriguez wrote:
>>> Coleen point out that it's confusing to reuse the name jump_from_interpreted since we're not really in the interpreter. I've changed it to jump_from_method_handle and left that note that it parallels jump_from_interpreted.
>> This looks good. Although I'm a little worried about the raise_exception changes on SPARC. In the past I had various crashes with versions that used the interpreter stack to pass the arguments. That's why I changed it to the simpler, more reliable current version (which uses the compiler calling convention). Maybe I got adjust_SP_and_Gargs_down_by_slots right and there is no problem now.
>> Just to be sure I'm currently running JRuby's benchmarks (my memory tells me that I had the crashes with these benchmarks) on two different SPARC boxes. I'll let you know when they are finished.
> Sorry, it took a little longer to run them because one of the benchmarks (bench_full_load_path.rb) does not finish (it hangs around doing nothing). Anyway, all others look good.
Thanks. I fixed the interp_only check to look more like the original code and reran the mlvm tests and they all look good.
> -- Christian
More information about the hotspot-compiler-dev