review request (URGENT): 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray

John Rose john.r.rose at
Tue Jun 14 18:18:29 PDT 2011

I have reviews from Christian and Tom; thanks.

For more accurate tracking, I have split out some of the changes into a different bug, 7054590:

The updated webrev for the remaining changes is here:

Please give it a quick re-review.

Besides the split, I also simplified the adjustment in to the GWT transformations, as follows:

         static boolean preferRicochetFrame(MethodType type) {
-            return (type.parameterCount() >= INVOKES.length || type.hasPrimitives());
+            return true;  // always use RF if available

This particular simplification has been "soaking" in the mlvm-dev builds since 6/03.

-- John

On Jun 13, 2011, at 9:22 PM, John Rose wrote:

> These are the JDK-side fixes for several crashes in method handle adapters.
> Summary of changes:
> - correct parameters of some rotate (OP_ROT_ARGS) permutation adapters
> - communicate the rotation convention with the JVM via OP_ROT_ARGS_DOWN_LIMIT_BIAS
> - adjust code in MethodHandleImpl for GWT transformations
> - fix typo in SwitchPoint javadoc
> - fix non-compliant logic in MethodHandleProxies
> - fix invalid private classes in MethodHandlesTest
> 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray
> Summary: Fix corner cases involving MethodHandles.permuteArguments with long or double argument lists.
> This bug also has a set of JVM-side fixes, which will also be posted for review.  A preview may be found in the mlvm patch repository:
> Both change sets are required to fix the bug.  Either change set is safe to apply by itself, and will cause no regression.
> Thanks,
> -- John

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the hotspot-compiler-dev mailing list