review for 7055355: JSR 292: crash while throwing WrongMethodTypeException

John Rose john.r.rose at
Thu Jun 16 14:13:12 PDT 2011

On Jun 16, 2011, at 2:05 PM, Tom Rodriguez wrote:

> I agree in theory but the only thing it's done so far is report false positives.  The old slop value was kind of in agreement with the save_frame size but I had to raise it to 45 to get it to shut up, with no apparent ill effects.  My last push raised it to 35.  After Christian's comments I decided to disabled it in my push since I think it's well intentioned but wrong.

Yes; I saw you commented it out.  That's fine for now.  I agree about the false positives.  Also, SPARC SPs are not corrupted as easily as on x86.

I just re-reviewed it; it looks good.  Thanks, Christian, for catching the SPARC problem.

-- John

More information about the hotspot-compiler-dev mailing list