Request for reviews (S): 7052494: Eclipse test fails on JDK 7 b142
vladimir.kozlov at oracle.com
Mon Jun 20 16:38:38 PDT 2011
Thank you, Tom
On 6/20/11 4:30 PM, Tom Rodriguez wrote:
> So the first file is just anti-deltaing those two changes that disallowed other forms which seems fine.
> The second file looks ok but I think the comment should say "can" instead of "could".
Agree, I will fix the comment.
> On Jun 17, 2011, at 4:57 PM, Vladimir Kozlov wrote:
>> This is for 7u2.
>> Fixed 7052494: Eclipse test fails on JDK 7 b142
>> New code in 5091921 fix incorrectly replaces loop test 'ne' with 'lt' (and with 'gt' for negative stride). As result loop's body is not executed when initial value> limit. Note, such loops are terminated usually by other checks inside loop's body (for example, range checks).
>> Keep 'ne' test when we can't guarantee during compilation that init< limit.
>> Regression test is added.
>> Tested with Eclipse tests.
More information about the hotspot-compiler-dev