review for 7042052: Xcomp crash with PopSynchronousTest

Vladimir Kozlov vladimir.kozlov at
Wed May 4 17:22:14 PDT 2011

Looks good.


Tom Rodriguez wrote:
> 7042052: Xcomp crash with PopSynchronousTest
> Reviewed-by:
> In the fix for 7009361 I added some logic in deoptimization to adjust
> interpreted callers by the size of the signature at the call site
> instead of the size of the callee since they can be different in the
> presence of invokedynamic.  The logic for computing the arguments was
> missing some parens so it grouped incorrecty returning either 1 or 0.
> We have so much extra space in our frames most of the time that
> nothing broke but luckily this test case showed the problem.  Tested
> with failing test case from report.

More information about the hotspot-compiler-dev mailing list