review request (L): 6939861: JVM should handle more conversion operations
john.r.rose at oracle.com
Fri May 6 00:27:28 PDT 2011
On May 5, 2011, at 11:58 PM, Christian Thalinger wrote:
> On May 5, 2011, at 1:16 PM, John Rose wrote:
>> I have finished the last large chunk of JVM work for JDK 7 JSR 292, the implementation of so-called "ricochet frames". Here it is for review:
>> 6939861: JVM should handle more conversion operations
> In DeoptimizationBlob::create you call trace_new_stub but the code that code factored out is still there.
> + // This opens space space for the return value.
> One space too much.
> + __ mov(saved_last_sp, rsp); // set rsi/r13 for calleee
> One e too much.
> All new header files have the wrong (Sun) copyright header.
I'm backing off from introducing new header files. The only new file is methodHandles_x86.hpp.
See what you think. The idea is to allow each port to control its own individual future relative to this refactoring. The logic is toward the bottom of this diff:
Also, this new webrev is relative to hotspot-comp, not bsd-port:
Thanks. I'm hoping we can put this in today, especially with the reduced dependency on port changes.
More information about the hotspot-compiler-dev