review(S): 7042153: guarantee(x_compare_res != Constant::not_comparable) failed: incomparable constants in IfOp

Vladimir Kozlov vladimir.kozlov at
Fri May 6 09:17:06 PDT 2011

Looks good to me. I would add a comment for changes in c1_Optimizer.cpp to 
explain why !can_trap() check is needed.


Igor Veresov wrote:
> In C1, during IfOp elimination we can try to fold and IfOp that has 
> constant objects as an arguments to the condition that are unloaded (not 
> known at compile time) and are going to be patched later.
> The solution is to check for such cases in make_ifop().
> Webrev:
> Tested with a short testcase, which I added to the regression suite.
> Thanks,
> igor

More information about the hotspot-compiler-dev mailing list