Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods
christian.thalinger at oracle.com
Wed Sep 7 12:09:27 PDT 2011
On Sep 7, 2011, at 8:52 PM, Tom Rodriguez wrote:
> On Sep 7, 2011, at 6:37 AM, Christian Thalinger wrote:
>> 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods
>> The current push notification of CallSites disallows the compilation
>> of CallSite.setTargetNormal and setTargetVolatile to get correct
>> behavior. It would be much easier and cleaner if these two methods
>> were native methods in the JVM.
> The JVM changes look fine, though the name obj_field_volatile_put doesn't read that well. Maybe obj_field_put_volatile? I know it matches the raw_put name but you could change that too. Anyway, it's a nit, so feel free to ignore it.
I agree. I will change that.
> In CallSite.java you can delete the other Unsafe stuff since it's no longer needed. Otherwise it looks good.
Like TARGET_OFFSET? getTargetVolatile still uses it.
>> The obsolete code will be removed after the JDK changes have landed
>> 7087357: JSR 292: remove obsolete code after 7085860
More information about the hotspot-compiler-dev