review for 7145537: minor tweaks to LogEvents

Christian Thalinger christian.thalinger at
Tue Feb 14 12:20:29 PST 2012

On Feb 14, 2012, at 9:13 PM, Tom Rodriguez wrote:

> 62 lines changed: 19 ins; 16 del; 27 mod; 9602 unchg
> 7145537: minor tweaks to LogEvents
> Reviewed-by:
> A few minor fixes and corrections to the LogEvents output.  Add the
> compile id and osr flag to the nmethod logging.  Switch all the times
> to the seconds since JVM start and print in standard %.3f format.
> Override PrintHeapAtGCExtended when logging the heap.  Move
> Events::print to the cpp to ease invoking it from the debugger.  I
> also restored the extern "C" events() function to use when the
> debugger is being difficult about invoking C++ methods.  I also
> expanded the logging of implicit exceptions to record more cases.  I
> considered removing the generate implicit exception logging since
> that's not as rare as the others.  Tested with crashing the JVM.


Since you added the C event() method again you probably should not remove the header and the help output.


+   // Dump all evemts to the tty


-- Chris

More information about the hotspot-compiler-dev mailing list