Request for reviews (S): 6658428: C2 doesn't inline java method if corresponding intrinsic failed to inline
tom.rodriguez at oracle.com
Tue Feb 21 11:05:53 PST 2012
On Feb 21, 2012, at 2:26 AM, Nils Eliasson wrote:
> 6658428: C2 doesn't inline java method if corresponding intrinsic failed to inline.
> Allow intrinsic inline to fallback to plain java inline case. Changing some intrinsics to not be created when they cant be used and adding some print inline changes.
I don't think you need to try inline and out of line separately. I think the old code forced out of line because that was the only way to suppress the use of the intrinsic. So remove the try_inline = false line and just add the extra false argument to the existing call. It should use inline if it's appropriate or out of line if not.
In library_call.cpp I think it would be better to stop using !UsePopCountInstruction to guard those intrinsics and use the appropriate Matcher::has_match_rule for each one. That should take into account the platform dependent meaning of UsePopCountIntstruction.
> And I will need someone to submit it.
> Nils E.
More information about the hotspot-compiler-dev