Request for reviews (M): 7201026: add vector for shift count

Christian Thalinger christian.thalinger at
Mon Oct 1 13:52:35 PDT 2012

On Sep 25, 2012, at 6:52 PM, Vladimir Kozlov <vladimir.kozlov at> wrote:

> Add generation of vectors for scalar shift count (same for all shift vector's elements).


+ const int Matcher::vector_shift_count_ideal_reg(int size) {
+   fatal("vector shift is not supported");
+   return Op_RegD;
+ }

It's just a nit but I think we should return -1 here.  Someone in the future might be confused.


+   ShouldNotReachHere();

Replace with default case and fatal?

Otherwise this looks good.

-- Chris

> Fixed test for RShiftVI case.
> Thanks,
> Vladimir

More information about the hotspot-compiler-dev mailing list