RFR (L): 7054512: Compress class pointers after perm gen removal

Roland Westrelin roland.westrelin at oracle.com
Wed Oct 3 08:33:28 PDT 2012


Thanks for the review and the suggestions.

> There are some places where the indent is now off and I'd like to get them fixed but it's really up to you.

Is this why you are referring to?

   case T_ARRAY:     return new (C) ConPNode( t->is_aryptr() );
   case T_ADDRESS:   return new (C) ConPNode( t->is_ptr() );
   case T_NARROWOOP: return new (C) ConNNode( t->is_narrowoop() );
+  case T_NARROWKLASS: return new (C) ConNKlassNode( t->is_narrowklass() );
   case T_METADATA:  return new (C) ConPNode( t->is_ptr() );

I would personally try to restrict the changeset to the lines that contribute to the feature. Is there an agreed coding "policy" for this?


More information about the hotspot-compiler-dev mailing list