Request for Reviews(M): 7092905: C2: Keep track of the number of dead nodes
bharadwaj.yadavalli at oracle.com
Mon Oct 29 14:06:58 PDT 2012
Thanks for pointing out the XML related issues, John.
I made the necessary changes to my log output such that valid XML code
is generated. I validated the resulting hotspot.log using xmllint.
On 10/29/2012 3:22 PM, John Rose wrote:
> On Oct 29, 2012, at 10:56 AM, Christian Thalinger wrote:
>> + _log->elem("node count before optimize compile_id='%d'
>> unique='%d' live (tracked)='%d' live(graph_walk)='%d'",
> Actually, that will emit invalid XML, even if the underscores are added:
> <node count before optimize compile_id='7' unique='%d' live
> (tracked)='44' live(graph_walk)='22'/>
> Not only are "count" and "before" bad attribute specifiers, but "live
> (tracked)='44'" is also. I suppose live(graph_walk)='22' is
> accidentally correct, but I wouldn't wish it on an XML parser.
> It might be worthwhile putting a debug-only validator of some sort to
> catch simple mistakes like this.
> — John
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev