RFR(S): 8016277: Crash in nmethod::is_compiled_by_c1() on x86
vladimir.kozlov at oracle.com
Wed Aug 21 13:34:27 PDT 2013
On 8/21/13 12:43 PM, Roland Westrelin wrote:
>> Why do we need asserts at all in is_compiled_by_* methods?
> That was a way to check the change left the behavior unchanged. I can remove them if you like.
You did change the behavior of these methods - they don't return false
now if _method == NULL.
Do you know why we rerun false before when _method == NULL?
It could be nulled in nmethod::make_unloaded() before your change.
What I am trying to say is if we treat these methods like wrapper around
compiler()->is_c*() call then we don't need asserts.
But if they have an other purpose (check _method == NULL) then it is
different and we should not change they behavior in such case.
More information about the hotspot-compiler-dev