RFR(M) 7199175: JSR 292: C1 needs patching when invokedynamic/invokehandle call site is not linked

Roland Westrelin roland.westrelin at oracle.com
Fri May 31 03:28:05 PDT 2013

Thanks for reviewing this, Vladimir.

> >> +  develop(bool, C1PatchInvokeDynamic, true,       \
> >>
> >> Do we really want to turn if off?  During development I'm sure it was helpful but after that?
> >
> > That's something John asked for.
> I agree with Christian that this flag is weird. Why you would want to bailout even for testing?

It's not a trivial change. So if tests that used to work start failing and this change is suspected, it will be as easy as running with -XX:-C1PatchInvokeDynamic to verify this change is the cause. I think it's a good idea to have this flag.

> Could you split some checks into 2 lines in c1_Runtime1.cpp? They are too long.

Here is a new webrev in case you want to check I split the right checks.



More information about the hotspot-compiler-dev mailing list