RFR (S): 8026775: nsk/jvmti/RedefineClasses/StressRedefine crashes due to EXCEPTION_ACCESS_VIOLATION

John Rose john.r.rose at oracle.com
Mon Nov 4 11:58:42 PST 2013

+   // Skip the first one because that was already touched in the above
+   // loop - the post decrement of temp means it's now a page below the
+   // last touch

The comments should say 'tmp' not 'temp'.  Also, the phrases 'first one' and 'it's now a page below' are hard to understand, and (to me) slightly misleading.

+   // At this point, (tmp-0) is the last address touched, so don't touch it again.
+   // (It was touched as (tmp-pagesize) but then tmp was post-decremented.)
+   // Skip this address by starting at i=1, and touch a few more pages below.
+   // N.B.  It is important to touch all the down to and including i=StackShadowPages.

— John

More information about the hotspot-compiler-dev mailing list