RFR(XS): 8027571: fatal error: meet not symmetric
vladimir.kozlov at oracle.com
Tue Nov 19 12:15:44 PST 2013
Thank you, Roland
The fix is good.
On 11/19/13 9:24 AM, Roland Westrelin wrote:
> Hi Vladimir,
> Thanks for reviewing this.
>> What code you are referencing: "what is done for instances”?
> I’m referencing to this:
> 3464 // Since klasses are different, we require a LCA in the Java
> 3465 // class hierarchy - which means we have to fall to at least NotNull.
> 3466 if( ptr == TopPTR || ptr == AnyNull || ptr == Constant )
> 3467 ptr = NotNull;
>> What about case TopPTR meet Constant which produce Constant?
> For instances, that case goes down to NotNull in some cases.
>> Can you, please, also fix comment's indent? And remove space in few cases: 'tap ->’.
>> On 11/18/13 12:40 PM, Roland Westrelin wrote:
>>> Similarly to what is done for instances, meet of exact classes in upper lattice or constant should fall down to NotNull.
More information about the hotspot-compiler-dev