RFR (XXS): 8025849: Redundant "pid" in VM log file name (e.g. hotspot_pidpid12345.log)

Azeem Jiva azeem.jiva at oracle.com
Thu Oct 3 14:42:18 PDT 2013

Did you test this on different OSes?  Just to make sure that %p does return 'pid#' rather than just '#'.  Windows would be a good one to test at the minimum.  Otherwise it's fine (not a real reviewer).

Azeem Jiva

On Oct 3, 2013, at 2:30 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> http://cr.openjdk.java.net/~vlivanov/8025849/webrev.00
> 2 lines changed: 0 ins; 0 del; 2 mod
> make_log_name function does the following expansion: %p => pid{pid}.
> Fix VM log file name, removing unnecessary "pid" from the pattern.
> FYI, I filed JDK-8025905 to track discrepancy between "%p" in LogFile & ErrorFile.
> Best regards,
> Vladimir Ivanov
> [1] https://bugs.openjdk.java.net/browse/JDK-8025905

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20131003/1b0769a9/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20131003/1b0769a9/signature.asc 

More information about the hotspot-compiler-dev mailing list