RFR (S): 8026478: -XX:+VerifyAdapterSharing is broken

Albert Noll albert.noll at oracle.com
Tue Oct 15 04:14:23 PDT 2013


could I have reviews for this small patch?

Bug: https://bugs.openjdk.java.net/browse/JDK-8026478
webrev: http://cr.openjdk.java.net/~anoll/8026478/webrev.00/ 

Problem: This flag is broken. The reason is that adapters 
(gen_i2c_adapter()) that are generated during VM startup do not include 
the range for StubRoutines::code2() if -XX:+VerifyAdapterCalls is 
specified. StubRoutines::code2() is only allocated later during startup; 
consequently, code2() is NULL. As a result, the size of the generated 
adapter as well as the code itself does not mactch.

Solution: Defer check (VerifyAdapterSharing) until VM is initialzied. 
Note that this patch also fixes potential issues with 
-XX:+VerifyAdapterCalls, which is a dignostic flag. The patch also 
removes some unused field of VerifyAdapterSharing.

Many thanks in advance,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20131015/ca9c5829/attachment.html 

More information about the hotspot-compiler-dev mailing list