RFR(L) 8026844: Various Math functions needs intrinsification

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Oct 18 08:50:42 PDT 2013


is_MathExactOpcode() could be replaced by adding the node to DEFINE_CLASS_ID structure as you did with FlagsProj. 
is_MathExact()  will be true for all its subclasses.

Put MathExactNode() constructors together.

In library_call.cpp can you name Integer version of method with I: inline_math_addExactI() to be symmetrical with Long 
version. And I don't think you need separate methods for increment and decrement - path flag to add and sub method.

Why you did not implement mulexact(reg, mem) mach nodes?

Otherwise it is good.


On 10/18/13 2:34 AM, Rickard Bäckman wrote:
> Hi, can I get reviews for the following change:
> This change creates intrinsics for addExact(long, long), subtractExact,
> negateExact, incrementExact, decrementExact and multiplyExact.
> The intrinsics are only added on x86 and only 64-bit has the intrinsics
> for the long-versions. (32-bit only has int-versions).
> Bug: https://bugs.openjdk.java.net/browse/JDK-8026844
> Webrev: http://cr.openjdk.java.net/~rbackman/8026844/
> Thanks
> /R

More information about the hotspot-compiler-dev mailing list