RFR (S): 8022494: Make compilation IDs sequential

Albert Noll albert.noll at oracle.com
Thu Oct 24 01:21:09 PDT 2013

Hi Aleksey,

thanks for looking at this.

On 24.10.2013 10:15, Aleksey Shipilev wrote:
> On 10/24/2013 12:01 PM, Albert Noll wrote:
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~anoll/8022494/webrev.03/
> Nice to see the locking gone.
> compileBroker.cpp:
>    * Is that considered correct that OSR and normal compilations are
> marked differently when running in debug mode, but not in release? I
> understand the comment before assign_compile_id, so this is more of the
> philosophical question.
Compilation IDs are only different if -XX:CICountOSR is set, which is
defaulted to false.
> sharedRuntime.cpp:
>    * Why do you need "2653   return;" in the method tail?
Thanks for spotting this. I missed it during the cleanup.

> Thanks,
> -Aleksey.

More information about the hotspot-compiler-dev mailing list