RFR (S): 8022494: Make compilation IDs sequential
albert.noll at oracle.com
Thu Oct 24 12:50:15 PDT 2013
thanks for looking at this. I'll fix the typos before pushing.
On 24.10.2013 18:12, Christian Thalinger wrote:
> *+ // The compilation falls outside the allowed range. Note that this can only happen in debug*
> *+ // build if the cIStart(OSR) and CIStop(OSR) flags at are specified. Since currently this wrapper*
> Typo: CIStart. Also, should this be: “flags are”?
> Otherwise this looks good.
> On Oct 24, 2013, at 1:56 AM, Albert Noll <albert.noll at oracle.com
> <mailto:albert.noll at oracle.com>> wrote:
>> Here is the updated webrev:
>> On 24.10.2013 10:21, Albert Noll wrote:
>>> Hi Aleksey,
>>> thanks for looking at this.
>>> On 24.10.2013 10:15, Aleksey Shipilev wrote:
>>>> On 10/24/2013 12:01 PM, Albert Noll wrote:
>>>>> Here is the updated webrev:
>>>> Nice to see the locking gone.
>>>> * Is that considered correct that OSR and normal compilations are
>>>> marked differently when running in debug mode, but not in release? I
>>>> understand the comment before assign_compile_id, so this is more of
>>>> philosophical question.
>>> Compilation IDs are only different if -XX:CICountOSR is set, which is
>>> defaulted to false.
>>>> * Why do you need "2653 return;" in the method tail?
>>> Thanks for spotting this. I missed it during the cleanup.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev