[9] RFR(S): 8043913: remove legacy code in SPARC's VM_Version::platform_features

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Aug 12 13:08:35 UTC 2014

Hi, Zoltan

I would suggest to replace next removed check with assert to make sure we have getisax:

if (os::Solaris::supports_getisax())

Otherwise it looks good.


On 8/12/14 12:12 AM, Zoltán Majó wrote:
> Hi,
> please remove the following patch.
> Problem: Since on SPARC we are now building/running on Solaris 10 and up, legacy code in the method
> VM_Version::platform_features can be removed.
> Solution: The getisax(2) call is available from Solaris 10, therefore legacy code to determine platform features can be
> removed. Solaris 10 defines some of the AV* constants used in the method. Some of these defines could have been removed
> as well, but different versions of Solaris 10 define different subsets of the constants, therefore it is better to leave
> the defines for now.
> Webrev: http://cr.openjdk.java.net/~thartmann/8043913/webrev.00/
> Testing:
> - built JVM on solaris_sparc_5.10u5 and on solaris_sparc_5.11.1;
> - ran all JPRT tests on the solaris_sparcv9* platform;
> - ran test/sanity/ExecuteInternalVMTests.java (the test executed by the "hotspot_compiler" JPRT test) on
> solaris_sparc_5.11.1, solaris_sparc_5.10u5, and solaris_sparc_5.10u6
> Thank you and best regards,
> Zoltan

More information about the hotspot-compiler-dev mailing list