RFR (L): JDK-8055903: Develop sanity tests on SPARC's SHA instructions support
vladimir.kozlov at oracle.com
Fri Aug 29 16:43:00 UTC 2014
On 8/29/14 9:37 AM, Filipp Zhinkin wrote:
> On 29.08.2014 20:32, Vladimir Kozlov wrote:
>> So it is mostly verification that intrinsic is used.
>> The code looks fine.
>> But what about testing that intrinsic produce correct data?
> It is done by compiler/intrinsics/sha/TestSHA.java test:
I know about this test but I though we may not cover all cases.
Did you evaluate it? I am fine if you think that everything is covered.
>> On 8/29/14 7:45 AM, Filipp Zhinkin wrote:
>>> Hi all,
>>> please review sanity tests on SHA intrinsics support.
>>> Tests verify that appropriate intrinsic is emitted whencorresponding
>>> option is enabled and not emitted ifsuch option is disabled.
>>> In case when CPU does not support required instructions or
>>> JVM configuration does not allow to use an intrinsic,
>>> the test will expect that intrinsic will not be emitted.
>>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8055903
>>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8055903/webrev.00/
>>> Testing: manual, automated.
More information about the hotspot-compiler-dev