RFR (XS): JDK-8066862: TestMutuallyExclusivePlatformPredicates fails on all platforms
filipp.zhinkin at oracle.com
Thu Dec 11 12:33:43 UTC 2014
thank you for review.
Bengt's fix already pushed into gc repo,
so I've just updated webrev to use gc repo instead of comp one:
On 12/10/2014 09:54 PM, Vladimir Kozlov wrote:
> Your changes are in conflict with 8067115 changes in hs-gc repo:
> Please, use gc repo instead of hs-comp and coordinate the push with Bengt.
> Otherwise looks good.
> On 12/10/14 5:48 AM, Filipp Zhinkin wrote:
>> Hi all,
>> please review a fix for 8066862.
>> testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java fails with
>> RuntimeException: All Platform's methods with signature '():Z' should be
>> Root cause:
>> In order to prevent issues caused by the fact that some mutually exclusive
>> predicates may return "true" on on the same platform (for example if
>> isARM and
>> isPPC will return true simultaneously) I decided to check in test if all
>> Platform's methods with '():Z' signature were tested.
>> Fix for 8039995 added new methods with "():Z" signature, but these
>> methods were
>> not marked in TestMutuallyExclusivePlatformPredicates as methods that
>> should be ignored.
>> Proposed fix:
>> Mark newly added methods as ignored in
>> add this test to sanity test group in order to run it in JPRT
>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8066862
>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8066862/webrev.00/
>> Testing: manual & automated
More information about the hotspot-compiler-dev