RFR (M) 8035605: Expand functionality of PredictedIntrinsicGenerator

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Jun 9 19:34:31 UTC 2014

Thank you, Roland

On 6/6/14 3:19 AM, Roland Westrelin wrote:
>> http://cr.openjdk.java.net/~kvn/8035605/webrev
> callGenerator.cpp:
>   892   PredicatedIntrinsicGenerator(CallGenerator* intrinsic,
>   893                               CallGenerator* cg)
> indentation is broken.


> What does that comment mean?
> 956     // Assert(no_new_memory && no_new_io && no_new_exceptions) after generate_predicate.

It was 'TODO' which I forgot. I added real asserts.

> In GraphKit::merge_memory(): _gvn.transform() is not called on the new PhiNodes. Wouldn’t we want to call it?

We can't call transform() in merge_memory() because we don't know when 
Phi node is completed (when all paths are processed). I added 
transformation loop after merge_memory() calls.

New webrev (only callGenerator.cpp was changed):



> Roland.

More information about the hotspot-compiler-dev mailing list